Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 176873012: Link chrome_elf.dll instead of statically linking the blacklist code (Closed)

Created:
6 years, 10 months ago by csharp
Modified:
6 years, 10 months ago
Reviewers:
robertshield, sky
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Link chrome_elf.dll instead of statically linking the blacklist code This ensure that the dll code is referenced, instead of the target making its own copy. BUG=329023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome_elf/chrome_elf.def View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
csharp
6 years, 10 months ago (2014-02-25 14:08:31 UTC) #1
robertshield
LGTM Could you update the description with a bug number that points to crbug.com/329023?
6 years, 10 months ago (2014-02-25 14:47:11 UTC) #2
csharp
sky@ for owner's approval of chrome/renderer/chrome_content_renderer_client.cc
6 years, 10 months ago (2014-02-25 15:05:02 UTC) #3
sky
LGTM
6 years, 10 months ago (2014-02-25 16:40:14 UTC) #4
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 10 months ago (2014-02-25 16:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/176873012/1
6 years, 10 months ago (2014-02-25 16:41:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/176873012/1
6 years, 10 months ago (2014-02-25 21:46:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/176873012/1
6 years, 10 months ago (2014-02-25 22:11:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/176873012/1
6 years, 10 months ago (2014-02-25 23:10:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/176873012/1
6 years, 10 months ago (2014-02-26 00:00:43 UTC) #10
commit-bot: I haz the power
Change committed as 253366
6 years, 10 months ago (2014-02-26 05:27:15 UTC) #11
ckocagil
6 years, 10 months ago (2014-02-26 11:20:02 UTC) #12
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/181343003/ by ckocagil@chromium.org.

The reason for reverting is: Broke unit_tests on Win 7 debug:

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%....

Powered by Google App Engine
This is Rietveld 408576698