Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/bindings/v8/custom/V8PannerNodeCustom.cpp

Issue 176873003: Remove type of panningModelType "soundfield". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/webaudio/pannernode-basic.html ('k') | Source/modules/webaudio/PannerNode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 return; 43 return;
44 if (!imp->setPanningModel(model)) { 44 if (!imp->setPanningModel(model)) {
45 exceptionState.throwTypeError("Illegal panningModel"); 45 exceptionState.throwTypeError("Illegal panningModel");
46 exceptionState.throwIfNeeded(); 46 exceptionState.throwIfNeeded();
47 } 47 }
48 return; 48 return;
49 } 49 }
50 50
51 if (value->IsString()) { 51 if (value->IsString()) {
52 String model = toCoreString(value.As<v8::String>()); 52 String model = toCoreString(value.As<v8::String>());
53 if (model == "equalpower" || model == "HRTF" || model == "soundfield") { 53 if (model == "equalpower" || model == "HRTF") {
54 imp->setPanningModel(model); 54 imp->setPanningModel(model);
55 return; 55 return;
56 } 56 }
57 } 57 }
58 58
59 exceptionState.throwTypeError("Illegal panningModel"); 59 exceptionState.throwTypeError("Illegal panningModel");
60 exceptionState.throwIfNeeded(); 60 exceptionState.throwIfNeeded();
61 } 61 }
62 62
63 void V8PannerNode::distanceModelAttributeSetterCustom(v8::Local<v8::Value> value , const v8::PropertyCallbackInfo<void>& info) 63 void V8PannerNode::distanceModelAttributeSetterCustom(v8::Local<v8::Value> value , const v8::PropertyCallbackInfo<void>& info)
(...skipping 20 matching lines...) Expand all
84 } 84 }
85 } 85 }
86 86
87 exceptionState.throwTypeError("Illegal distanceModel"); 87 exceptionState.throwTypeError("Illegal distanceModel");
88 exceptionState.throwIfNeeded(); 88 exceptionState.throwIfNeeded();
89 } 89 }
90 90
91 } // namespace WebCore 91 } // namespace WebCore
92 92
93 #endif // ENABLE(WEB_AUDIO) 93 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « LayoutTests/webaudio/pannernode-basic.html ('k') | Source/modules/webaudio/PannerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698