Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 176873003: Remove type of panningModelType "soundfield". (Closed)

Created:
6 years, 10 months ago by KhNo
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Raymond Toy, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove type of panningModelType "soundfield". One of panningModelType "soundfiled" had been not implemented until now. In addition, the last W3C Spec about webaudio, has been deleted about this feature. http://www.w3.org/TR/webaudio/ The code about "soundfiled" seems to be removed in blink. BUG=346191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M LayoutTests/webaudio/pannernode-basic.html View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8PannerNodeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/PannerNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/modules/webaudio/PannerNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/audio/Panner.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/audio/Panner.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
KhNo
Please review my patch.
6 years, 10 months ago (2014-02-24 10:31:38 UTC) #1
Ken Russell (switch to Gerrit)
LGTM, but please wait for Raymond's review as well.
6 years, 10 months ago (2014-02-24 18:23:13 UTC) #2
Raymond Toy (Google)
On 2014/02/24 18:23:13, Ken Russell wrote: > LGTM, but please wait for Raymond's review as ...
6 years, 10 months ago (2014-02-24 23:11:44 UTC) #3
Raymond Toy (Google)
On 2014/02/24 23:11:44, rtoy wrote: > On 2014/02/24 18:23:13, Ken Russell wrote: > > LGTM, ...
6 years, 10 months ago (2014-02-24 23:14:23 UTC) #4
KhNo
haraken@chromium.org: Please review changes in
6 years, 10 months ago (2014-02-25 01:35:05 UTC) #5
haraken
LGTM.
6 years, 10 months ago (2014-02-25 01:39:30 UTC) #6
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 10 months ago (2014-02-25 01:55:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176873003/1
6 years, 10 months ago (2014-02-25 01:56:14 UTC) #8
KhNo
The CQ bit was unchecked by keonho07.kim@samsung.com
6 years, 10 months ago (2014-02-25 01:56:16 UTC) #9
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 10 months ago (2014-02-25 01:58:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176873003/1
6 years, 10 months ago (2014-02-25 01:58:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176873003/1
6 years, 10 months ago (2014-02-25 05:19:36 UTC) #12
KhNo
The CQ bit was unchecked by keonho07.kim@samsung.com
6 years, 10 months ago (2014-02-25 05:46:05 UTC) #13
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 10 months ago (2014-02-25 05:46:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176873003/1
6 years, 10 months ago (2014-02-25 07:41:32 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 08:07:21 UTC) #16
Message was sent while issue was closed. 
Change committed as 167750

Powered by Google App Engine
This is Rietveld 408576698