Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1768653002: Fix the coordinates for touch selection. (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix the coordinates for touch selection. * The selection bounds attached to CompositorFrameMetaData is in viewport coordinates. This needs to be converted to DIP for browser somewhere. For now, this CL convert it in browser side rather than renderer side because the code that computes the selection bounds is in cc/ rather than content/renderer. Consider move that part ot content/renderer and move this to there instead. BUG=585043 TEST=TouchSelectionControllerClientAuraScaleFactorTest*. manual. TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/1740193002 Cr-Commit-Position: refs/heads/master@{#378500} (cherry picked from commit 93b827d99389ad0ce61362695ad641b14ca33180) Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869, 485650 Review URL: https://codereview.chromium.org/1745523002 Cr-Commit-Position: refs/heads/master@{#378153} (cherry picked from commit 131114a6dd70fabb949d7f05f3c9759bcf701281) Committed: https://chromium.googlesource.com/chromium/src/+/e16a6fa53ebd538abd802b189f1063bad267b575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -80 lines) Patch
M content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc View 20 chunks +228 lines, -71 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/test/data/touch_selection.html View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 9 months ago (2016-03-04 20:54:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e16a6fa53ebd538abd802b189f1063bad267b575.

Powered by Google App Engine
This is Rietveld 408576698