net/dns/host_resolver_impl.cc - Issue 1768643002: Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP literal and HOST_RE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 1768643002: Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP literal and HOST_RE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index af91b09f5e2cb9f5a4ba9c4586877575e8e34071..aa37485f8f4d5e47962e4a3c274cbe8f9655bd74 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -2092,11 +2092,6 @@ bool HostResolverImpl::ResolveAsIP(const Key& key,

if (ip_number == nullptr)

return false;

- DCHECK_EQ(key.host_resolver_flags &

- ~(HOST_RESOLVER_CANONNAME | HOST_RESOLVER_LOOPBACK_ONLY |

- HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6),

- 0) << " Unhandled flag";

*net_error = OK;

AddressFamily family = GetAddressFamily(*ip_number);

if (key.address_family != ADDRESS_FAMILY_UNSPECIFIED &&

« no previous file with comments | « no previous file | net/dns/host_resolver_impl_unittest.cc » ('j') | no next file with comments »