Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP literal and HOST_RE

Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706
Committed: https://crrev.com/368a1007f97c81c0d0a8e15a8affdcdd429dad5a
Cr-Commit-Position: refs/heads/master@{#379372}

[eroman, 2016-03-04 20:07:15]

Description was changed from

==========
Remove an unnecessary (and incorrect) DCHECK().

In particular it is legitimate for the flag to be HOST_RESOLVER_SYSTEM_ONLY.

The existing DCHECK() then becomes a whitelist for *all* flags, so remove it
instead.

BUG=591706
==========

to

==========
Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP
literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence
firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial
whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706
==========

[eroman, 2016-03-04 20:08:02]

eroman@chromium.org changed reviewers:
+ juliatuttle@chromium.org, tuttle@chromium.org

[Deprecated (see juliatuttle), 2016-03-04 20:20:05]

lgtm.

[Deprecated (see juliatuttle), 2016-03-04 20:20:18]

ttuttle@chromium.org changed reviewers:
+ ttuttle@chromium.org
- juliatuttle@chromium.org, tuttle@chromium.org

[eroman, 2016-03-04 20:31:14]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-03-04 20:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768643002/1

[commit-bot: I haz the power, 2016-03-04 21:53:07]

Description was changed from

==========
Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP
literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence
firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial
whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706
==========

to

==========
Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP
literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence
firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial
whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706
==========

[commit-bot: I haz the power, 2016-03-04 21:53:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 21:55:18]

Description was changed from

==========
Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP
literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence
firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial
whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706
==========

to

==========
Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP
literal and HOST_RESOLVER_SYSTEM_ONLY flag.

The existing DCHECK() what a whitelist for all flags except this one and hence
firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial
whitelist of everything so just remove the DCHECK all-together instead.

BUG=591706

Committed: https://crrev.com/368a1007f97c81c0d0a8e15a8affdcdd429dad5a
Cr-Commit-Position: refs/heads/master@{#379372}
==========

[commit-bot: I haz the power, 2016-03-04 21:55:19]

Patchset 1 (id:??) landed as
https://crrev.com/368a1007f97c81c0d0a8e15a8affdcdd429dad5a
Cr-Commit-Position: refs/heads/master@{#379372}