Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1768633002: Fix testing/scripts/mojo_apptests.py command for Windows. (Closed)

Created:
4 years, 9 months ago by msw
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix testing/scripts/mojo_apptests.py command for Windows. Use sys.executable to run the python script on Windows. BUG=592043 TEST=Step passes on Windows. TBR=dpranke@chromium.org Committed: https://crrev.com/bb63eb68c886cd3dd5f0e30d73e1e7d52b942958 Cr-Commit-Position: refs/heads/master@{#379354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/scripts/mojo_apptests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Dirk, PTAL as you have time; landing.
4 years, 9 months ago (2016-03-04 19:13:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768633002/1
4 years, 9 months ago (2016-03-04 19:13:42 UTC) #3
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-04 20:38:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 20:57:36 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 20:59:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb63eb68c886cd3dd5f0e30d73e1e7d52b942958
Cr-Commit-Position: refs/heads/master@{#379354}

Powered by Google App Engine
This is Rietveld 408576698