Issue 176863009: Have NodeWithIndex deal with references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176863009: Have NodeWithIndex deal with references instead of pointers (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
adamk, rwlbuis

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Have NodeWithIndex deal with references instead of pointers Have NodeWithIndex deal with references instead of pointers. This makes the code look safer. R=adamk@chromium.org, adamk, rwlbuis Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168418

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -37 lines)			Patch
M	Source/core/dom/Document.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/NodeWithIndex.h	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	Source/core/dom/Range.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Range.cpp	View		1 chunk	+19 lines, -21 lines	0 comments	Download
M	Source/core/dom/Text.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/176863009/1

6 years, 9 months ago (2014-03-04 19:53:01 UTC) #3

Inactive

6 years, 9 months ago (2014-03-05 02:44:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r168418 (presubmit successful).