Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 176863005: Add is_tracing to browser. (Closed)

Created:
6 years, 9 months ago by nednguyen
Modified:
6 years, 9 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add is_tracing_running to browser. Add is_timeline_recording_running to web_contents. Add is_video_capture_running to tab. BUG=348271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255559

Patch Set 1 #

Patch Set 2 : Add is_tracing to browser #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Add is_video_capture_running #

Patch Set 6 : Add is_video_capture_running #

Patch Set 7 : Add unittests #

Patch Set 8 : Add unittests #

Total comments: 1

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_timeline.py View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 2 3 4 5 6 7 8 9 4 chunks +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 2 3 4 5 6 1 chunk +6 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
tools/telemetry/telemetry/core/tab.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 2 3 4 5 6 7 2 chunks +41 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/web_contents.py View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
nednguyen
6 years, 9 months ago (2014-03-03 18:22:25 UTC) #1
nduca
can you add unit test coverage?
6 years, 9 months ago (2014-03-05 23:42:15 UTC) #2
nednguyen
On 2014/03/05 23:42:15, nduca wrote: > can you add unit test coverage? Done
6 years, 9 months ago (2014-03-06 01:08:02 UTC) #3
nduca
lgtm https://codereview.chromium.org/176863005/diff/140001/tools/telemetry/telemetry/core/browser_unittest.py File tools/telemetry/telemetry/core/browser_unittest.py (right): https://codereview.chromium.org/176863005/diff/140001/tools/telemetry/telemetry/core/browser_unittest.py#newcode175 tools/telemetry/telemetry/core/browser_unittest.py:175: b = self.CreateBrowser() this test should return early ...
6 years, 9 months ago (2014-03-06 22:39:04 UTC) #4
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-06 23:42:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/176863005/160001
6 years, 9 months ago (2014-03-06 23:44:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 23:44:55 UTC) #7
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-06 23:44:55 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-06 23:53:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/176863005/180001
6 years, 9 months ago (2014-03-06 23:57:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 02:18:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 02:18:54 UTC) #12
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-07 04:10:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/176863005/180001
6 years, 9 months ago (2014-03-07 04:13:56 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:05:48 UTC) #15
Message was sent while issue was closed.
Change committed as 255559

Powered by Google App Engine
This is Rietveld 408576698