Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart

Issue 1768613002: Update codeOffset/codeLength during incremental resolution. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
index cf2c0dda5cd198ab6f1412d4eaf4b236f221d02f..f4a8966b531330da8f289ffd1d5814ee31af378e 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
@@ -849,7 +849,13 @@ class _SameResolutionValidator implements AstVisitor {
return;
}
if (a.nameOffset != b.nameOffset) {
- _fail('Expected: ${b.nameOffset}\n Actual: ${a.nameOffset}');
+ _fail('nameOffset\nExpected: ${b.nameOffset}\n Actual: ${a.nameOffset}');
+ }
+ if (a is ElementImpl && b is ElementImpl && a.codeOffset != b.codeOffset) {
+ _fail('codeOffset\nExpected: ${b.codeOffset}\n Actual: ${a.codeOffset}');
+ }
+ if (a is ElementImpl && b is ElementImpl && a.codeLength != b.codeLength) {
Brian Wilkerson 2016/03/04 19:28:03 This code is duplicated.
scheglov 2016/03/04 19:36:31 Done.
+ _fail('codeLength\nExpected: ${b.codeLength}\n Actual: ${a.codeLength}');
}
if (a is LocalElement && b is LocalElement) {
if (a.visibleRange != b.visibleRange) {
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698