Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1768613002: Update codeOffset/codeLength during incremental resolution. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update codeOffset/codeLength during incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/822fa6c912e9a0f54c48f65bd5751a943b1544bf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Extract comparing values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart View 1 2 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 9 months ago (2016-03-04 18:42:41 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1768613002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart File pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart (right): https://codereview.chromium.org/1768613002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart#newcode857 pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart:857: if (a is ElementImpl && b is ElementImpl ...
4 years, 9 months ago (2016-03-04 19:28:03 UTC) #2
scheglov
https://codereview.chromium.org/1768613002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart File pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart (right): https://codereview.chromium.org/1768613002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart#newcode857 pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart:857: if (a is ElementImpl && b is ElementImpl && ...
4 years, 9 months ago (2016-03-04 19:36:31 UTC) #3
scheglov
4 years, 9 months ago (2016-03-04 19:36:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
822fa6c912e9a0f54c48f65bd5751a943b1544bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698