Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1768593002: [Interpreter] Removes TestNotEqualsStrict bytecode from interpreter. (Closed)

Created:
4 years, 9 months ago by mythria
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Removes TestNotEqualsStrict bytecode from interpreter. TestNotEqualsStrict is converted to a TestEqualsStrict and logical not by the parser. Also, CompareIC does not have an implementation for TestNotEqualsStrict. Hence, removing this bytecode. BUG=v8:4280 LOG=N Committed: https://crrev.com/e06d57b05de332780fc11876bb2d6009a2b3e8ba Cr-Commit-Position: refs/heads/master@{#34527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -23 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +73 lines, -5 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768593002/1
4 years, 9 months ago (2016-03-04 16:56:46 UTC) #2
mythria
PTAL, Thanks, Mythri
4 years, 9 months ago (2016-03-04 17:17:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 17:21:40 UTC) #8
oth
lgtm, but it'll need an additional reviewer for compiler and tests.. The wording of the ...
4 years, 9 months ago (2016-03-05 02:00:12 UTC) #9
rmcilroy
LGTM (+1 to Orion's comment).
4 years, 9 months ago (2016-03-05 03:23:55 UTC) #10
mythria
Michi, PTAL at compiler changes. It just removes TestNotEqualsStrict bytecode Orion, Thanks, I updated the ...
4 years, 9 months ago (2016-03-07 09:34:53 UTC) #13
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-07 09:45:07 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768593002/1
4 years, 9 months ago (2016-03-07 09:49:37 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 10:16:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768593002/1
4 years, 9 months ago (2016-03-07 10:41:58 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 10:49:58 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 10:50:53 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e06d57b05de332780fc11876bb2d6009a2b3e8ba
Cr-Commit-Position: refs/heads/master@{#34527}

Powered by Google App Engine
This is Rietveld 408576698