Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1768583002: temporary fix for repos that directly used DownloadHooks from git_cl.py. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

temporary fix for repos that directly used DownloadHooks from git_cl.py. TBR=phajdan.jr@chromium.org,andybons@chromium.org BUG=579176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M git_cl.py View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1762343002 Patch 1

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768583002/1
4 years, 9 months ago (2016-03-04 15:52:23 UTC) #2
tandrii(chromium)
i knew it'd not go well, but when something not even in depot_tools imports git_cl ...
4 years, 9 months ago (2016-03-04 15:53:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299106
4 years, 9 months ago (2016-03-04 15:55:00 UTC) #5
tandrii(chromium)
4 years, 9 months ago (2016-03-04 16:29:32 UTC) #6
Message was sent while issue was closed. 
reference bug: 579176

Powered by Google App Engine
This is Rietveld 408576698