Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/objects-inl.h

Issue 1768553002: [runtime] Clean up symbol access in identity hash code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-dictionary.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7092 matching lines...) Expand 10 before | Expand all | Expand 10 after
7103 return iter.GetCurrent() != global; 7103 return iter.GetCurrent() != global;
7104 } 7104 }
7105 7105
7106 7106
7107 Handle<Smi> JSReceiver::GetOrCreateIdentityHash(Handle<JSReceiver> object) { 7107 Handle<Smi> JSReceiver::GetOrCreateIdentityHash(Handle<JSReceiver> object) {
7108 return object->IsJSProxy() 7108 return object->IsJSProxy()
7109 ? JSProxy::GetOrCreateIdentityHash(Handle<JSProxy>::cast(object)) 7109 ? JSProxy::GetOrCreateIdentityHash(Handle<JSProxy>::cast(object))
7110 : JSObject::GetOrCreateIdentityHash(Handle<JSObject>::cast(object)); 7110 : JSObject::GetOrCreateIdentityHash(Handle<JSObject>::cast(object));
7111 } 7111 }
7112 7112
7113 7113 Handle<Object> JSReceiver::GetIdentityHash(Isolate* isolate,
7114 Object* JSReceiver::GetIdentityHash() { 7114 Handle<JSReceiver> receiver) {
7115 return IsJSProxy() 7115 return receiver->IsJSProxy() ? JSProxy::GetIdentityHash(
7116 ? JSProxy::cast(this)->GetIdentityHash() 7116 isolate, Handle<JSProxy>::cast(receiver))
7117 : JSObject::cast(this)->GetIdentityHash(); 7117 : JSObject::GetIdentityHash(
7118 isolate, Handle<JSObject>::cast(receiver));
7118 } 7119 }
7119 7120
7120 7121
7121 bool AccessorInfo::all_can_read() { 7122 bool AccessorInfo::all_can_read() {
7122 return BooleanBit::get(flag(), kAllCanReadBit); 7123 return BooleanBit::get(flag(), kAllCanReadBit);
7123 } 7124 }
7124 7125
7125 7126
7126 void AccessorInfo::set_all_can_read(bool value) { 7127 void AccessorInfo::set_all_can_read(bool value) {
7127 set_flag(BooleanBit::set(flag(), kAllCanReadBit, value)); 7128 set_flag(BooleanBit::set(flag(), kAllCanReadBit, value));
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
7747 #undef WRITE_INT64_FIELD 7748 #undef WRITE_INT64_FIELD
7748 #undef READ_BYTE_FIELD 7749 #undef READ_BYTE_FIELD
7749 #undef WRITE_BYTE_FIELD 7750 #undef WRITE_BYTE_FIELD
7750 #undef NOBARRIER_READ_BYTE_FIELD 7751 #undef NOBARRIER_READ_BYTE_FIELD
7751 #undef NOBARRIER_WRITE_BYTE_FIELD 7752 #undef NOBARRIER_WRITE_BYTE_FIELD
7752 7753
7753 } // namespace internal 7754 } // namespace internal
7754 } // namespace v8 7755 } // namespace v8
7755 7756
7756 #endif // V8_OBJECTS_INL_H_ 7757 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-dictionary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698