Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1768553002: [runtime] Clean up symbol access in identity hash code (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Clean up symbol access in identity hash code BUG= Committed: https://crrev.com/433fd6c078fb1ec13b56b5220ada890fabc0edf7 Cr-Commit-Position: refs/heads/master@{#34497}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M src/objects.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/objects.cc View 3 chunks +19 lines, -21 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -5 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-04 14:10:35 UTC) #3
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-04 14:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768553002/40001
4 years, 9 months ago (2016-03-04 14:13:57 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 14:38:43 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 14:39:18 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/433fd6c078fb1ec13b56b5220ada890fabc0edf7
Cr-Commit-Position: refs/heads/master@{#34497}

Powered by Google App Engine
This is Rietveld 408576698