Source/core/rendering/svg/RenderSVGInlineText.cpp - Issue 176853009: Fix crash in SVGFontFaceElement::associatedFontElement crash when removing SVGFontFaceElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGInlineText.cpp

Issue 176853009: Fix crash in SVGFontFaceElement::associatedFontElement crash when removing SVGFontFaceElement. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed patch conflict Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/RenderSVGInlineText.cpp

diff --git a/Source/core/rendering/svg/RenderSVGInlineText.cpp b/Source/core/rendering/svg/RenderSVGInlineText.cpp

index 5a6420c786e6e7183e4331576266ba73194404ae..93c1be524fae410eaff5d4c965bae2391d8d5f63 100644

--- a/Source/core/rendering/svg/RenderSVGInlineText.cpp

+++ b/Source/core/rendering/svg/RenderSVGInlineText.cpp

@@ -94,7 +94,7 @@ void RenderSVGInlineText::styleDidChange(StyleDifference diff, const RenderStyle

// The text metrics may be influenced by style changes.

if (RenderSVGText* textRenderer = RenderSVGText::locateRenderSVGTextAncestor(this))

- textRenderer->subtreeStyleDidChange(this);

+ textRenderer->setNeedsLayout();

}

InlineTextBox* RenderSVGInlineText::createTextBox()

« no previous file with comments | « LayoutTests/fast/dom/discard-svg-font-face-crash-expected.svg ('k') | Source/core/rendering/svg/RenderSVGText.h » ('j') | no next file with comments »