Source/web/WebSearchableFormData.cpp - Issue 176853004: Oilpan: move core/fileapi to oilpan's heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSearchableFormData.cpp

Issue 176853004: Oilpan: move core/fileapi to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + add missing USED_FROM_MULTIPLE_THREADS(Event) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSearchableFormData.cpp

diff --git a/Source/web/WebSearchableFormData.cpp b/Source/web/WebSearchableFormData.cpp

index 83579afe4580df768bd13ce9f41be7b4b5ef8ac5..5c3197d56223335b0c7d97db3c5c9e1e8a5ff176 100644

--- a/Source/web/WebSearchableFormData.cpp

+++ b/Source/web/WebSearchableFormData.cpp

@@ -211,9 +211,9 @@ bool buildSearchString(const HTMLFormElement* form, Vector<char>* encodedString,

if (!control->appendFormData(dataList, false))

continue;

- const Vector<FormDataList::Item>& items = dataList.items();

+ const WillBeHeapVector<FormDataList::Item>& items = dataList.items();

- for (Vector<FormDataList::Item>::const_iterator j(items.begin()); j != items.end(); ++j) {

+ for (WillBeHeapVector<FormDataList::Item>::const_iterator j(items.begin()); j != items.end(); ++j) {

// Handle ISINDEX / <input name=isindex> specially, but only if it's

// the first entry.

if (!encodedString->isEmpty() || j->data() != "isindex") {