Chromium Code Reviews| Index: Source/core/html/forms/FileInputType.h |
| diff --git a/Source/core/html/forms/FileInputType.h b/Source/core/html/forms/FileInputType.h |
| index a675ec9aa9fc4733b6e1729bd0d3d480c6dc264a..79b7709694a8a018bb3461b38b08f57ae8daf9f4 100644 |
| --- a/Source/core/html/forms/FileInputType.h |
| +++ b/Source/core/html/forms/FileInputType.h |
| @@ -33,6 +33,7 @@ |
| #define FileInputType_h |
| #include "core/html/forms/BaseClickableWithKeyInputType.h" |
| +#include "heap/Handle.h" |
| #include "platform/FileChooser.h" |
| #include "wtf/RefPtr.h" |
| @@ -58,7 +59,7 @@ private: |
| virtual RenderObject* createRenderer(RenderStyle*) const OVERRIDE; |
| virtual bool canSetStringValue() const OVERRIDE; |
| virtual FileList* files() OVERRIDE; |
| - virtual void setFiles(PassRefPtr<FileList>) OVERRIDE; |
| + virtual void setFiles(PassRefPtrWillBeRawPtr<FileList>) OVERRIDE; |
| virtual bool canSetValue(const String&) OVERRIDE; |
| virtual bool getTypeSpecificValue(String&) OVERRIDE; // Checked first, before internal storage or the value attribute. |
| virtual void setValue(const String&, bool valueChanged, TextFieldEventBehavior) OVERRIDE; |
| @@ -73,10 +74,10 @@ private: |
| // FileChooserClient implementation. |
| virtual void filesChosen(const Vector<FileChooserFileInfo>&) OVERRIDE; |
| - PassRefPtr<FileList> createFileList(const Vector<FileChooserFileInfo>& files) const; |
| + PassRefPtrWillBeRawPtr<FileList> createFileList(const Vector<FileChooserFileInfo>& files) const; |
| void receiveDropForDirectoryUpload(const Vector<String>&); |
| - RefPtr<FileList> m_fileList; |
| + RefPtrWillBePersistent<FileList> m_fileList; |
|
sof
2014/02/24 13:12:43
This persistent isn't promptly released & GCed on
haraken
2014/02/24 13:49:14
Why isn't FileInputType destructed on shutdown? Wh
sof
2014/02/24 17:09:09
I don't see FileInputType's dtor being called on a
haraken
2014/02/25 01:37:47
Would you mind digging into the issue? This sounds
|
| String m_droppedFileSystemId; |
| }; |