setup the correct version of Xcode

scripts/slave/recipes/flutter/flutter.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 
 DEPS = [
   'depot_tools/git',
   'file',
   'gsutil',
+  'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
   'recipe_engine/step',
 ]
 
 BUCKET_NAME = 'flutter_infra'
 
 
 def GetCloudPath(api, git_hash, path):
@@ skipping 99 matching lines @@
     if api.platform.is_linux:
       cloud_path = GetCloudPath(api, git_hash, 'examples/%s' % apk_name)
       api.gsutil.upload(app_path.join('build/app.apk'), BUCKET_NAME, cloud_path,
           link_name=apk_name, name='upload %s' % apk_name)
 
   # TODO(eseidel): We should not have to hard-code the desired apk name here.
   ArchiveAPK(api, 'examples/stocks', 'Stocks.apk')
   ArchiveAPK(api, 'examples/material_gallery', 'Gallery.apk')
 
 
+def RunFindXcode(target_version=None):
+  """Runs the `build/scripts/slave/ios/find_xcode.py` utility to retrieve
+     information about xcode installations and to activate a specific version
+     of Xcode.
+  """
+  import json
+  import os
+  import string
+  import subprocess
+  import sys
+  import tempfile

[iannucci, 2016/03/04 17:58:05]

Whoops. This not lgtm for sure. This will break the recipes system entirely :).

+
+  scripts_dir = os.path.dirname(os.path.dirname(os.path.dirname(
+    os.path.dirname(os.path.abspath(__file__)))))
+
+  find_xcode_py_path = os.path.join(
+    scripts_dir,

[eseidel1, 2016/03/04 04:25:05]

I think this is api.path['build'].join('scripts'), but I'd have to look at other
recipes to be sure.

[yjbanov, 2016/03/04 17:45:50]

I tried that, but for some reason api.path['build'].join('foo') takes me to
'build/scripts/build/foo', and if I do api.path['foo'] it says it doesn't know
what 'foo' is.

[iannucci, 2016/03/04 17:58:05]

This should be rewritten to use the recipe apis to invoke this script.
api.path['build'] should be what you want... if it's not then there's a bug in
the recipe engine (but I think a lot of things would break in that case).

+    'slave/ios/find_xcode.py'
+  )
+
+  json_file = tempfile.mkstemp(prefix='xcode-info')[1]
+
+  args = [
+    find_xcode_py_path,
+    '--json-file', json_file,
+  ]
+
+  if target_version is not None:
+    args.extend(['--version', '7.2.1'])
+
+  find_proc = subprocess.Popen(args, stdout=subprocess.PIPE,
+    stderr=subprocess.PIPE, cwd=scripts_dir, env={'PYTHONPATH': scripts_dir})
+
+  (stdout, stderr) = find_proc.communicate()
+  if find_proc.returncode != 0:
+    raise Exception(find_proc.returncode, stdout, stderr)
+
+  with open(json_file, 'r') as xcode_info_reader:
+    return json.loads(xcode_info_reader.read())
+
+
+def SetupXcode(api):
+  if api.platform.is_mac:
+    xcode_json = RunFindXcode()
+    installations = xcode_json["installations"]
+    activate_version = None
+    for key in installations:
+      version = installations[key].split()[0]
+      if version.startswith('7.'):
+        activate_version = version
+        break
+    if activate_version is None:
+      raise Exception('Xcode version 7 or above not found')
+    print 'Activating Xcode version %s' % version
+    RunFindXcode(target_version=activate_version)
+
+
 def RunSteps(api):
   # buildbot sets 'clobber' to the empty string which is falsey, check with 'in'
   if 'clobber' in api.properties:
     api.file.rmcontents('everything', api.path['slave_build'])
 
   git_hash = api.git.checkout(
       'https://chromium.googlesource.com/external/github.com/flutter/flutter',
       recursive=True, set_got_revision=True)
   checkout = api.path['checkout']
 
   api.step('download android tools',
       [checkout.join('infra', 'download_android_tools.py')])
 
   dart_bin = checkout.join('bin', 'cache', 'dart-sdk', 'bin')
   flutter_bin = checkout.join('bin')
   # TODO(eseidel): This is named exactly '.pub-cache' as a hack around
   # a regexp in flutter_tools analyze.dart which is in turn a hack around:
   # https://github.com/dart-lang/sdk/issues/25722
   pub_cache = api.path['slave_build'].join('.pub-cache')
   env = {
     'PATH': api.path.pathsep.join((str(flutter_bin), str(dart_bin),
         '%(PATH)s')),
     # Setup our own pub_cache to not affect other slaves on this machine.
     'PUB_CACHE': pub_cache,
     'ANDROID_HOME': checkout.join('infra', 'android_tools'),
   }
 
   # The context adds dart-sdk tools to PATH sets PUB_CACHE.
   with api.step.context({'env': env}):
+    SetupXcode(api)

[eseidel1, 2016/03/04 04:25:06]

Do you need to take the results of finding XCode to set the DEVELOPER_DIR env
variable for xcrun?

[yjbanov, 2016/03/04 17:45:50]

The `find_xcode.py` utility uses `xcode-select` to switch xcrun to the correct
version. We shouldn't need extra env variables.

+
     # Must be first to download dependencies for later steps.
     api.step('flutter doctor', ['flutter', 'doctor'])
     api.step('update packages', ['flutter', 'update-packages'])
     AnalyzeFlutter(api)
     TestFlutterPackagesAndExamples(api)
     BuildExamples(api, git_hash)
 
     # TODO(yjbanov): we do not yet have Android devices hooked up, nor do we
     # support the Android emulator. For now, only run on iOS Simulator.
     if api.platform.is_mac:
       TestCreateAndLaunch(api)
 
     # TODO(eseidel): We only want to generate one copy of the docs at a time
     # otherwise multiple rsyncs could race, causing badness. We'll eventually
     # need both a lock on the bucket, as well as some assurance that we're
     # always moving the docs forward. Possibly by using a separate builder.
     # Until then, only generate on linux to reduce the chance of race.
     if api.platform.is_linux:
       # TODO(eseidel): Is there a way for GenerateDocs to read PUB_CACHE from
       # the env instead of me passing it in?
       GenerateDocs(api, pub_cache)
 
 
 def GenTests(api):
   for platform in ('mac', 'linux'):
     yield (api.test(platform) + api.platform(platform, 64) +
         api.properties(clobber=''))