Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issue 1768443003: [runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy BUG=148757 LOG=n Committed: https://crrev.com/4e46149f5af53e91ca24ca871ae121ddd14f6fb5 Cr-Commit-Position: refs/heads/master@{#34495}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/api.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-04 12:58:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768443003/20001
4 years, 9 months ago (2016-03-04 13:04:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 13:22:45 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 13:23:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e46149f5af53e91ca24ca871ae121ddd14f6fb5
Cr-Commit-Position: refs/heads/master@{#34495}

Powered by Google App Engine
This is Rietveld 408576698