Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 176843021: Remove redundancies of multiply() in FFTFrame. (Closed)

Created:
6 years, 9 months ago by KhNo
Modified:
6 years, 9 months ago
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove redundancies of multiply() in FFTFrame. There is code redundancies of multiply() in FFTFrame for every port even if it is exactly same. Move to FFTFrame.cpp for removing redundancies. BUG=349945 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168721

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -94 lines) Patch
M Source/platform/audio/FFTFrame.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/platform/audio/FFTFrame.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M Source/platform/audio/FFTFrameStub.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/platform/audio/ipp/FFTFrameIPP.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/platform/audio/mac/FFTFrameMac.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
KhNo
Please review the patch set. Thanks. :)
6 years, 9 months ago (2014-03-06 17:00:36 UTC) #1
eae
+ jochen, thakis On 2014/03/06 17:00:36, KhNo wrote: > Please review the patch set. Thanks. ...
6 years, 9 months ago (2014-03-06 17:19:40 UTC) #2
Raymond Toy (Google)
+kbr who is an owner. lgtm. Note that historically they were all slightly different until ...
6 years, 9 months ago (2014-03-06 17:51:51 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
6 years, 9 months ago (2014-03-06 18:14:45 UTC) #4
KhNo
On 2014/03/06 18:14:45, Ken Russell wrote: > lgtm Thank you.
6 years, 9 months ago (2014-03-07 00:04:56 UTC) #5
KhNo
On 2014/03/06 17:51:51, rtoy wrote: > +kbr who is an owner. > > lgtm. > ...
6 years, 9 months ago (2014-03-07 00:05:16 UTC) #6
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-07 04:43:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176843021/20001
6 years, 9 months ago (2014-03-07 04:43:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:28:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-07 05:28:45 UTC) #10
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-07 07:45:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/176843021/20001
6 years, 9 months ago (2014-03-07 07:46:02 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 08:42:40 UTC) #13
Message was sent while issue was closed.
Change committed as 168721

Powered by Google App Engine
This is Rietveld 408576698