Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 176843018: Only use the non-strict-arguments-stub if the store site is non-strict. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Only use the non-strict-arguments-stub if the store site is non-strict. BUG=349874 LOG=N R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19690

Patch Set 1 #

Patch Set 2 : Fix the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/ic.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress-keyed-store-non-strict-arguments.js View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 9 months ago (2014-03-06 11:49:46 UTC) #1
mvstanton
lgtm
6 years, 9 months ago (2014-03-06 11:53:13 UTC) #2
Toon Verwaest
6 years, 9 months ago (2014-03-06 12:19:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19690 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698