Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 176843016: Add GM that directly tests GrRRectEffect and add inverse fill version of effect. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add GM that directly tests GrRRectEffect and add inverse fill version of effect. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13653

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : remove empty else #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -66 lines) Patch
M gm/rrects.cpp View 1 2 4 chunks +94 lines, -27 lines 0 comments Download
M include/core/SkRRect.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.h View 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 15 chunks +49 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-04 15:53:08 UTC) #1
robertphillips
lgtm + 1 clean up Q https://codereview.chromium.org/176843016/diff/20001/gm/rrects.cpp File gm/rrects.cpp (right): https://codereview.chromium.org/176843016/diff/20001/gm/rrects.cpp#newcode121 gm/rrects.cpp:121: tt.target()->drawSimpleRect(bounds); remove the ...
6 years, 9 months ago (2014-03-04 16:05:15 UTC) #2
bsalomon
https://codereview.chromium.org/176843016/diff/20001/gm/rrects.cpp File gm/rrects.cpp (right): https://codereview.chromium.org/176843016/diff/20001/gm/rrects.cpp#newcode121 gm/rrects.cpp:121: tt.target()->drawSimpleRect(bounds); On 2014/03/04 16:05:15, robertphillips wrote: > remove the ...
6 years, 9 months ago (2014-03-04 16:10:38 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-04 16:10:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/176843016/40001
6 years, 9 months ago (2014-03-04 16:10:51 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 16:25:37 UTC) #6
Message was sent while issue was closed.
Change committed as 13653

Powered by Google App Engine
This is Rietveld 408576698