Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 176843008: Remove |disable_drawing| flag from GLSurface::InitializeOneOffForTests. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, jbauman+watch_chromium.org, sadrul, Ian Vollick, tfarina, ben+aura_chromium.org, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, ben+ash_chromium.org, piman
Visibility:
Public.

Description

Remove |disable_drawing| flag from GLSurface::InitializeOneOffForTests. This flag is always passed as true now that all test suites opt in for it, so we can remove it. R=sievers, sky, joi BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254837

Patch Set 1 #

Patch Set 2 : rmdisabledraw: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M ash/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/cc_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ui/keyboard/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
danakj
6 years, 9 months ago (2014-03-03 18:12:52 UTC) #1
no sievers
lgtm
6 years, 9 months ago (2014-03-03 18:43:47 UTC) #2
danakj
Thanks! ben or sky: PTAL for src/ owners please. On Mon, Mar 3, 2014 at ...
6 years, 9 months ago (2014-03-03 18:48:37 UTC) #3
sky
LGTM
6 years, 9 months ago (2014-03-03 22:04:24 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-03 23:48:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/176843008/20001
6 years, 9 months ago (2014-03-03 23:49:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 00:10:28 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53196
6 years, 9 months ago (2014-03-04 00:10:29 UTC) #8
danakj
TBR=ben for the components/ change to remove the temporary argument.
6 years, 9 months ago (2014-03-04 16:22:30 UTC) #9
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-04 16:22:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/176843008/20001
6 years, 9 months ago (2014-03-04 16:24:05 UTC) #11
Jói
//components LGTM.
6 years, 9 months ago (2014-03-04 16:34:17 UTC) #12
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 9 months ago (2014-03-04 16:34:38 UTC) #13
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-04 16:34:54 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 21:30:21 UTC) #15
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-04 21:30:22 UTC) #16
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-04 21:40:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/176843008/20001
6 years, 9 months ago (2014-03-04 21:45:24 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 21:52:43 UTC) #19
Message was sent while issue was closed.
Change committed as 254837

Powered by Google App Engine
This is Rietveld 408576698