src/code-stubs-hydrogen.cc - Issue 176843006: Introduce representation types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs-hydrogen.cc

Issue 176843006: Introduce representation types (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use smi MSB Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs-hydrogen.cc

diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc

index 6bb011829c04e7b07b993e9c56442ce37a2d13a1..978494eec62b2c4bd2690a90abec63fa50c2ff9a 100644

--- a/src/code-stubs-hydrogen.cc

+++ b/src/code-stubs-hydrogen.cc

@@ -930,7 +930,7 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {

// If we encounter a generic argument, the number conversion is

// observable, thus we cannot afford to bail out after the fact.

if (!state.HasSideEffects()) {

- if (result_type->Is(Type::Smi())) {

+ if (result_type->Is(Type::SignedSmall())) {

if (state.op() == Token::SHR) {

// TODO(olivf) Replace this by a SmiTagU Instruction.

// 0x40000000: this number would convert to negative when interpreting

« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/types.h » ('J')