Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4429)

Unified Diff: build/gyp_chromium

Issue 176843005: Use ninja as the default GYP generator on FreeBSD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 8bfe62e200ea8a58025632f94dbe2e768a8b9785..d756598442c8c61736dda4537242145b058feda4 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -471,7 +471,9 @@ if __name__ == '__main__':
# . chromium.gyp_env has been applied to os.environ at this point already
if sys.platform.startswith('linux') and not os.environ.get('GYP_GENERATORS'):
os.environ['GYP_GENERATORS'] = 'ninja'
- if sys.platform.startswith('win') and not os.environ.get('GYP_GENERATORS'):
+ elif sys.platform.startswith('win') and not os.environ.get('GYP_GENERATORS'):
+ os.environ['GYP_GENERATORS'] = 'ninja'
+ elif sys.platform.startswith('freebsd') and not os.environ.get('GYP_GENERATORS'):
scottmg 2014/03/03 17:31:09 80 col also, can you rewrite these three if as:
r.c.ladan 2014/03/04 18:39:45 Done.
os.environ['GYP_GENERATORS'] = 'ninja'
elif sys.platform == 'darwin' and not os.environ.get('GYP_GENERATORS') and \
not 'OS=ios' in os.environ.get('GYP_DEFINES', []):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698