Use ninja as the default GYP generator on FreeBSD.

Use ninja as the default GYP generator on FreeBSD.

While here, consistently use a single 'if' statement to set this
environment variable.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254856

[scottmg, 2014-03-03 17:31:08]

https://codereview.chromium.org/176843005/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/176843005/diff/1/build/gyp_chromium#newcode476
build/gyp_chromium:476: elif sys.platform.startswith('freebsd') and not
os.environ.get('GYP_GENERATORS'):
80 col

also, can you rewrite these three if as:

if sys.platform.startswith(('linux', 'win', 'freebsd')) and not ...

[r.c.ladan, 2014-03-04 18:39:44]

https://codereview.chromium.org/176843005/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/176843005/diff/1/build/gyp_chromium#newcode476
build/gyp_chromium:476: elif sys.platform.startswith('freebsd') and not
os.environ.get('GYP_GENERATORS'):
On 2014/03/03 17:31:09, scottmg wrote:
> 80 col
> 
> also, can you rewrite these three if as:
> 
> if sys.platform.startswith(('linux', 'win', 'freebsd')) and not ...

Done.

[scottmg, 2014-03-04 18:40:27]

lgtm

[r.c.ladan, 2014-03-04 18:52:15]

The CQ bit was checked by r.c.ladan@gmail.com

[commit-bot: I haz the power, 2014-03-04 18:52:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/176843005/20001

[commit-bot: I haz the power, 2014-03-04 22:32:07]

Change committed as 254856