Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 176843004: Add IncrementWorkerRefCount() and DecrementWorkerRefCount() to RenderProcessHostImpl. (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 9 months ago
Reviewers:
kinuko, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add IncrementWorkerRefCount() and DecrementWorkerRefCount() to RenderProcessHostImpl. These methods will be called from SharedWorkerServiceImpl when the existence of the other renderer process which is connected to the SharedWorker in this renderer process has changed. It is only called when "enable-embedded-shared-worker" flag is set. When |worker_ref_count_| is not zero , RenderProcessHostImpl::FastShutdownIfPossible() and RenderProcessHostImpl::Cleanup() don't shutdown the renderer process. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255018

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : RenderProcessHostImpl::NotifySharedWorkerHasClients() #

Total comments: 1

Patch Set 4 : IncrementWorkerRefCount DecrementWorkerRefCount #

Patch Set 5 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -25 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 4 chunks +43 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
kinuko@ Please review this cl.
6 years, 9 months ago (2014-03-03 14:16:18 UTC) #1
kinuko
It'd be better to have this reviewed by content/ experts... adding jam@ (are you back?) ...
6 years, 9 months ago (2014-03-04 04:48:48 UTC) #2
horo
https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h File content/public/browser/render_process_host.h (right): https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h#newcode234 content/public/browser/render_process_host.h:234: virtual void SetExternalClientStatus(bool has_external_worker_client) = 0; On 2014/03/04 04:48:48, ...
6 years, 9 months ago (2014-03-04 06:40:43 UTC) #3
kinuko
https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h File content/public/browser/render_process_host.h (right): https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h#newcode234 content/public/browser/render_process_host.h:234: virtual void SetExternalClientStatus(bool has_external_worker_client) = 0; On 2014/03/04 06:40:43, ...
6 years, 9 months ago (2014-03-04 06:58:46 UTC) #4
horo
On 2014/03/04 06:58:46, kinuko wrote: > https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h > File content/public/browser/render_process_host.h (right): > > https://codereview.chromium.org/176843004/diff/1/content/public/browser/render_process_host.h#newcode234 > ...
6 years, 9 months ago (2014-03-04 07:25:21 UTC) #5
kinuko
looks reasonable to me, but would like to defer this to jam@
6 years, 9 months ago (2014-03-04 08:43:25 UTC) #6
horo
On 2014/03/04 08:43:25, kinuko wrote: > looks reasonable to me, but would like to defer ...
6 years, 9 months ago (2014-03-04 10:32:19 UTC) #7
jam
it's hard for me to say for sure as I don't see the calling code, ...
6 years, 9 months ago (2014-03-04 17:14:41 UTC) #8
horo
On 2014/03/04 17:14:41, jam wrote: > it's hard for me to say for sure as ...
6 years, 9 months ago (2014-03-05 03:21:31 UTC) #9
jam
lgtm
6 years, 9 months ago (2014-03-05 08:37:22 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-05 08:38:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/176843004/100001
6 years, 9 months ago (2014-03-05 08:39:55 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 12:06:13 UTC) #13
Message was sent while issue was closed.
Change committed as 255018

Powered by Google App Engine
This is Rietveld 408576698