Make the status reporting of devices in status_check more verbose.

Make the status reporting of devices in status_check more verbose.

Replaces the unknowns we keep seeing with either usb_failure, missing,
or offline.

missing: Shows up in lsusb but not adb.
usb_failure: Shows up in lsusb but can't reset the device via /dev/bus.
offline: Doesn't show up in lsusb or adb.

BUG=592666
Committed: https://crrev.com/b77e46bcf692f5106bb51d0b12bb3027b2ae6fef
Cr-Commit-Position: refs/heads/master@{#380028}

[bpastene, 2016-03-07 22:40:53]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org

[bpastene, 2016-03-07 22:40:54]

ptal

[bpastene, 2016-03-08 00:06:46]

bpastene@chromium.org changed reviewers:
+ mikecase@chromium.org

[bpastene, 2016-03-08 00:06:47]

I just realized John isn't the only owner of build/android. Time to spread the
love around!

[jbudorick, 2016-03-08 00:08:49]

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:148: if not
_IsBlacklisted(serial, blacklist):
Can we instead invert these two if statements s.t. we have

  if not _IsBlacklisted(serial, blacklist):
    if adb_status == 'device':
      ...
    else:
      blacklist.Extend(...)

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:403: elif
status.get('usb_status', False):
note that this will only appear on the slave page, not the build page. not sure
if that's what you intended to change here or not.

[bpastene, 2016-03-08 00:26:02]

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:148: if not
_IsBlacklisted(serial, blacklist):
On 2016/03/08 00:08:49, jbudorick wrote:
> Can we instead invert these two if statements s.t. we have
> 
>   if not _IsBlacklisted(serial, blacklist):
>     if adb_status == 'device':
>       ...
>     else:
>       blacklist.Extend(...)

Good catch. Done.

https://codereview.chromium.org/1768423002/diff/1/build/android/buildbot/bb_d...
build/android/buildbot/bb_device_status_check.py:403: elif
status.get('usb_status', False):
On 2016/03/08 00:08:49, jbudorick wrote:
> note that this will only appear on the slave page, not the build page. not
sure
> if that's what you intended to change here or not.

Yeah, I just wanted to clean that slave page up a bit while I was at it.

[bpastene, 2016-03-08 23:00:33]

pingly friend

This is one of the last blockers for turning on the automated ticket gen.

[jbudorick, 2016-03-08 23:13:27]

https://codereview.chromium.org/1768423002/diff/20001/build/android/buildbot/...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/1768423002/diff/20001/build/android/buildbot/...
build/android/buildbot/bb_device_status_check.py:187: else:
er, this should stay elif blacklist s.t. it doesn't wind up calling a method on
None.

[bpastene, 2016-03-08 23:36:32]

https://codereview.chromium.org/1768423002/diff/20001/build/android/buildbot/...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/1768423002/diff/20001/build/android/buildbot/...
build/android/buildbot/bb_device_status_check.py:187: else:
On 2016/03/08 23:13:27, jbudorick wrote:
> er, this should stay elif blacklist s.t. it doesn't wind up calling a method
on
> None.

Done.

[jbudorick, 2016-03-08 23:37:52]

lgtm

[bpastene, 2016-03-09 00:25:59]

The CQ bit was checked by bpastene@chromium.org

[commit-bot: I haz the power, 2016-03-09 00:26:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768423002/40001

[commit-bot: I haz the power, 2016-03-09 01:51:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-09 01:52:35]

Description was changed from

==========
Make the status reporting of devices in status_check more verbose.

Replaces the unknowns we keep seeing with either usb_failure, missing,
or offline.

missing: Shows up in lsusb but not adb.
usb_failure: Shows up in lsusb but can't reset the device via /dev/bus.
offline: Doesn't show up in lsusb or adb.

BUG=592666
==========

to

==========
Make the status reporting of devices in status_check more verbose.

Replaces the unknowns we keep seeing with either usb_failure, missing,
or offline.

missing: Shows up in lsusb but not adb.
usb_failure: Shows up in lsusb but can't reset the device via /dev/bus.
offline: Doesn't show up in lsusb or adb.

BUG=592666

Committed: https://crrev.com/b77e46bcf692f5106bb51d0b12bb3027b2ae6fef
Cr-Commit-Position: refs/heads/master@{#380028}
==========

[commit-bot: I haz the power, 2016-03-09 01:52:36]

Patchset 3 (id:??) landed as
https://crrev.com/b77e46bcf692f5106bb51d0b12bb3027b2ae6fef
Cr-Commit-Position: refs/heads/master@{#380028}