Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 1768383002: S390: Initial impl of regexp (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase to master and sort file in alphabetic ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1297 lines, -31 lines) Patch
M BUILD.gn View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/regexp/jsregexp.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/regexp/regexp-macro-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
A + src/regexp/s390/regexp-macro-assembler-s390.h View 1 6 chunks +24 lines, -24 lines 0 comments Download
A src/regexp/s390/regexp-macro-assembler-s390.cc View 1 chunk +1256 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768383002/1
4 years, 9 months ago (2016-03-07 21:05:38 UTC) #2
john.yan
S390: Initial impl of regexp
4 years, 9 months ago (2016-03-07 21:14:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 21:26:08 UTC) #5
Jakob Kummerow
LGTM (rubberstamping *-s390.{h,cc}) Jochen, please give src/regexp/OWNERS approval. https://codereview.chromium.org/1768383002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1768383002/diff/1/BUILD.gn#newcode1680 BUILD.gn:1680: "src/regexp/s390/regexp-macro-assembler-s390.cc", ...
4 years, 9 months ago (2016-03-08 09:50:27 UTC) #6
john.yan
On 2016/03/08 09:50:27, Jakob wrote: > LGTM (rubberstamping *-s390.{h,cc}) > > Jochen, please give src/regexp/OWNERS ...
4 years, 9 months ago (2016-03-08 13:09:42 UTC) #8
Yang
On 2016/03/08 13:09:42, john.yan wrote: > On 2016/03/08 09:50:27, Jakob wrote: > > LGTM (rubberstamping ...
4 years, 9 months ago (2016-03-08 14:35:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768383002/40001
4 years, 9 months ago (2016-03-08 14:47:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-08 15:08:06 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 15:08:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be33a9d89da370aee73a8b31011ab5b1b46dd0d7
Cr-Commit-Position: refs/heads/master@{#34592}

Powered by Google App Engine
This is Rietveld 408576698