Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 1768373003: Treat typemapped kinds as un-cloneable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/pylib/mojom/generate/module.py
diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
index 6a86f167f9d3735835b031ceec6cbbd188294068..a673d8eef6011015fe057044197b1e77aba9f896 100644
--- a/mojo/public/tools/bindings/pylib/mojom/generate/module.py
+++ b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
@@ -607,7 +607,7 @@ def IsMoveOnlyKind(kind):
IsAnyHandleKind(kind) or IsInterfaceKind(kind) or IsAssociatedKind(kind)
-def IsCloneableKind(kind):
+def IsCloneableKind(kind, filter):
def _IsCloneable(kind, visited_kinds):
if kind in visited_kinds:
# No need to examine the kind again.
@@ -618,7 +618,7 @@ def IsCloneableKind(kind):
if IsArrayKind(kind):
return _IsCloneable(kind.kind, visited_kinds)
if IsStructKind(kind) or IsUnionKind(kind):
- if IsStructKind(kind) and kind.native_only:
+ if IsStructKind(kind) and (kind.native_only or filter(kind)):
return False
for field in kind.fields:
if not _IsCloneable(field.kind, visited_kinds):
« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698