Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1768373003: Treat typemapped kinds as un-cloneable (Closed)

Created:
4 years, 9 months ago by darin (slow to review)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat typemapped kinds as un-cloneable BUG=592883 Committed: https://crrev.com/6de36cc8c2260493d0775c57ef4d591d309d33f1 Cr-Commit-Position: refs/heads/master@{#379789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Rockot(use gerrit already)
This seems reasonable to me. I think suppressing Clone generation is a good idea (actually ...
4 years, 9 months ago (2016-03-08 06:13:13 UTC) #2
darin (slow to review)
On 2016/03/08 06:13:13, Ken Rockot wrote: > This seems reasonable to me. I think suppressing ...
4 years, 9 months ago (2016-03-08 07:28:42 UTC) #3
darin (slow to review)
4 years, 9 months ago (2016-03-08 07:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768373003/1
4 years, 9 months ago (2016-03-08 07:29:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 08:40:16 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 08:41:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6de36cc8c2260493d0775c57ef4d591d309d33f1
Cr-Commit-Position: refs/heads/master@{#379789}

Powered by Google App Engine
This is Rietveld 408576698