Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1768283002: Switch SkComposeImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@if-follow-on
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch SkComposeImageFilter over to new onFilterImage interface This CL depends on https://codereview.chromium.org/1762013002/ (Swap over to using SkImageFilter::filterImage instead of filterImageDeprecated) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768283002 Committed: https://skia.googlesource.com/skia/+/40736abf74908dfed82567ba88432103c9a7e900

Patch Set 1 #

Patch Set 2 : Remove extra include file #

Patch Set 3 : update to ToT #

Patch Set 4 : Update for naming convention #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M include/effects/SkComposeImageFilter.h View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 2 3 2 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
robertphillips
4 years, 9 months ago (2016-03-07 18:44:34 UTC) #4
robertphillips
4 years, 9 months ago (2016-03-07 18:44:34 UTC) #5
Stephen White
LGTM
4 years, 9 months ago (2016-03-07 18:47:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768283002/40001
4 years, 9 months ago (2016-03-08 16:50:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768283002/60001
4 years, 9 months ago (2016-03-08 16:57:08 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 17:17:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768283002/60001
4 years, 9 months ago (2016-03-08 19:38:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768283002/60001
4 years, 9 months ago (2016-03-08 20:04:43 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 20:05:40 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/40736abf74908dfed82567ba88432103c9a7e900

Powered by Google App Engine
This is Rietveld 408576698