src/ia32/code-stubs-ia32.cc - Issue 1768233002: [wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 1768233002: [wasm] Int64Lowering of I64ShrU and I64ShrS on ia32. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 47b93d601a88ef34f1103175e3da063a868c94a7..70b488398243ce2ea691a81e16c2eb493f072cb1 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -275,7 +275,7 @@ void DoubleToIStub::Generate(MacroAssembler* masm) {

Immediate(static_cast<uint32_t>(Double::kSignificandMask >> 32)));

__ add(result_reg,

Immediate(static_cast<uint32_t>(Double::kHiddenBit >> 32)));

- __ shrd(result_reg, scratch1);

+ __ shrd_cl(scratch1, result_reg);

__ shr_cl(result_reg);

__ test(ecx, Immediate(32));

__ cmov(not_equal, scratch1, result_reg);