[wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

test/unittests/compiler/int64-lowering-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/int64-lowering.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node.h"
 
@@ skipping 356 matching lines @@
   Matcher<Node*> shl_matcher = IsWord32PairShl(
       IsInt32Constant(low_word_value(0)), IsInt32Constant(high_word_value(0)),
       IsInt32Constant(low_word_value(1)));
 
   EXPECT_THAT(graph()->end()->InputAt(1),
               IsReturn2(IsProjection(0, AllOf(CaptureEq(&shl), shl_matcher)),
                         IsProjection(1, AllOf(CaptureEq(&shl), shl_matcher)),
                         start(), start()));
 }
 // kExprI64ShrU:
+TEST_F(Int64LoweringTest, Int64ShrU) {
+  if (4 != kPointerSize) return;

[titzer, 2016/03/07 19:25:35]

Sorry I didn't notice this before. You shouldn't check the pointer size, but you
should make a MachineOperatorBuilder with the appropriate word size. Similarly
in in64-lowering; you should check the word size of the MachineOperatorBuilder.

[ahaas, 2016/03/08 07:58:42]

I created a separate CL(https://codereview.chromium.org/1770333002) for this.

+
+  LowerGraph(graph()->NewNode(machine()->Word64Shr(), Int64Constant(value(0)),
+                              Int64Constant(value(1))),
+             MachineRepresentation::kWord64);
+
+  Capture<Node*> shr;
+  Matcher<Node*> shr_matcher = IsWord32PairShr(
+      IsInt32Constant(low_word_value(0)), IsInt32Constant(high_word_value(0)),
+      IsInt32Constant(low_word_value(1)));
+
+  EXPECT_THAT(graph()->end()->InputAt(1),
+              IsReturn2(IsProjection(0, AllOf(CaptureEq(&shr), shr_matcher)),
+                        IsProjection(1, AllOf(CaptureEq(&shr), shr_matcher)),
+                        start(), start()));
+}
 // kExprI64ShrS:
+TEST_F(Int64LoweringTest, Int64ShrS) {
+  if (4 != kPointerSize) return;
+
+  LowerGraph(graph()->NewNode(machine()->Word64Sar(), Int64Constant(value(0)),
+                              Int64Constant(value(1))),
+             MachineRepresentation::kWord64);
+
+  Capture<Node*> sar;
+  Matcher<Node*> sar_matcher = IsWord32PairSar(
+      IsInt32Constant(low_word_value(0)), IsInt32Constant(high_word_value(0)),
+      IsInt32Constant(low_word_value(1)));
+
+  EXPECT_THAT(graph()->end()->InputAt(1),
+              IsReturn2(IsProjection(0, AllOf(CaptureEq(&sar), sar_matcher)),
+                        IsProjection(1, AllOf(CaptureEq(&sar), sar_matcher)),
+                        start(), start()));
+}
 // kExprI64Eq:
 TEST_F(Int64LoweringTest, Int64Eq) {
   if (4 != kPointerSize) return;
 
   LowerGraph(graph()->NewNode(machine()->Word64Equal(), Int64Constant(value(0)),
                               Int64Constant(value(1))),
              MachineRepresentation::kWord32);
   EXPECT_THAT(
       graph()->end()->InputAt(1),
       IsReturn(IsWord32Equal(
@@ skipping 46 matching lines @@
 // kExprF64SConvertI64:
 // kExprF64UConvertI64:
 // kExprI64SConvertF32:
 // kExprI64SConvertF64:
 // kExprI64UConvertF32:
 // kExprI64UConvertF64:
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8