Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: google_apis/gcm/gcm_client_impl.cc

Issue 176823009: Show device information in chrome://gcm-internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Display android id as well. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« google_apis/gcm/engine/mcs_client.cc ('K') | « google_apis/gcm/gcm_client_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/gcm_client_impl.cc
diff --git a/google_apis/gcm/gcm_client_impl.cc b/google_apis/gcm/gcm_client_impl.cc
index 46b246d3a4baa06ae65b422acd2cf8382f3d73f6..b095b388488bf30b0099287636fd00f362c19ac0 100644
--- a/google_apis/gcm/gcm_client_impl.cc
+++ b/google_apis/gcm/gcm_client_impl.cc
@@ -413,6 +413,37 @@ void GCMClientImpl::Send(const std::string& app_id,
mcs_client_->SendMessage(mcs_message);
}
+std::string GCMClientImpl::GetStateString() const {
+ switch(state_) {
+ case GCMClientImpl::INITIALIZED:
+ return "INITIALIZED";
+ case GCMClientImpl::UNINITIALIZED:
+ return "UNINITIALIZED";
+ case GCMClientImpl::LOADING:
+ return "LOADING";
+ case GCMClientImpl::INITIAL_DEVICE_CHECKIN:
+ return "INITIAL_DEVICE_CHECKIN";
+ case GCMClientImpl::READY:
+ return "READY";
+ default:
+ return std::string();
jianli 2014/03/06 01:55:21 nit: add NOTREACHED().
juyik 2014/03/06 02:23:59 Done.
+ }
+}
+
+GCMClient::GCMStatistics GCMClientImpl::GetStatistics() const {
+ GCMClient::GCMStatistics stats;
+ stats.gcm_client_state = GCMClientImpl::GetStateString();
+ stats.connection_client_created = mcs_client_.get() != NULL;
+ if (mcs_client_.get()) {
+ stats.connection_state = mcs_client_->GetStateString();
+ // TODO(juyik): add more statistics such as message metadata list, etc.
+ }
+ if (device_checkin_info_.android_id > 0) {
jianli 2014/03/06 01:55:21 nit: brackets are not needed
juyik 2014/03/06 02:23:59 Done.
+ stats.android_id = device_checkin_info_.android_id;
+ }
+ return stats;
+}
+
void GCMClientImpl::OnMessageReceivedFromMCS(const gcm::MCSMessage& message) {
switch (message.tag()) {
case kLoginResponseTag:
« google_apis/gcm/engine/mcs_client.cc ('K') | « google_apis/gcm/gcm_client_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698