Chromium Code Reviews| Index: google_apis/gcm/gcm_client_impl.cc |
| diff --git a/google_apis/gcm/gcm_client_impl.cc b/google_apis/gcm/gcm_client_impl.cc |
| index 46b246d3a4baa06ae65b422acd2cf8382f3d73f6..b095b388488bf30b0099287636fd00f362c19ac0 100644 |
| --- a/google_apis/gcm/gcm_client_impl.cc |
| +++ b/google_apis/gcm/gcm_client_impl.cc |
| @@ -413,6 +413,37 @@ void GCMClientImpl::Send(const std::string& app_id, |
| mcs_client_->SendMessage(mcs_message); |
| } |
| +std::string GCMClientImpl::GetStateString() const { |
| + switch(state_) { |
| + case GCMClientImpl::INITIALIZED: |
| + return "INITIALIZED"; |
| + case GCMClientImpl::UNINITIALIZED: |
| + return "UNINITIALIZED"; |
| + case GCMClientImpl::LOADING: |
| + return "LOADING"; |
| + case GCMClientImpl::INITIAL_DEVICE_CHECKIN: |
| + return "INITIAL_DEVICE_CHECKIN"; |
| + case GCMClientImpl::READY: |
| + return "READY"; |
| + default: |
| + return std::string(); |
|
jianli
2014/03/06 01:55:21
nit: add NOTREACHED().
juyik
2014/03/06 02:23:59
Done.
|
| + } |
| +} |
| + |
| +GCMClient::GCMStatistics GCMClientImpl::GetStatistics() const { |
| + GCMClient::GCMStatistics stats; |
| + stats.gcm_client_state = GCMClientImpl::GetStateString(); |
| + stats.connection_client_created = mcs_client_.get() != NULL; |
| + if (mcs_client_.get()) { |
| + stats.connection_state = mcs_client_->GetStateString(); |
| + // TODO(juyik): add more statistics such as message metadata list, etc. |
| + } |
| + if (device_checkin_info_.android_id > 0) { |
|
jianli
2014/03/06 01:55:21
nit: brackets are not needed
juyik
2014/03/06 02:23:59
Done.
|
| + stats.android_id = device_checkin_info_.android_id; |
| + } |
| + return stats; |
| +} |
| + |
| void GCMClientImpl::OnMessageReceivedFromMCS(const gcm::MCSMessage& message) { |
| switch (message.tag()) { |
| case kLoginResponseTag: |