Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: google_apis/gcm/gcm_client_impl.h

Issue 176823009: Show device information in chrome://gcm-internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/gcm_client_impl.h
diff --git a/google_apis/gcm/gcm_client_impl.h b/google_apis/gcm/gcm_client_impl.h
index 72b86bab65f49ba9162472ec4f1e57395f802479..edd7b4582af0023d5e04c9bea57dba06b6c846c7 100644
--- a/google_apis/gcm/gcm_client_impl.h
+++ b/google_apis/gcm/gcm_client_impl.h
@@ -64,9 +64,12 @@ class GCM_EXPORT GCMClientImpl : public GCMClient {
virtual void Send(const std::string& app_id,
const std::string& receiver_id,
const OutgoingMessage& message) OVERRIDE;
+ virtual GCMStatistics GetStatistics() const OVERRIDE;
private:
// State representation of the GCMClient.
+ // Any change made to this enum should have corresponding change in the
+ // GetStateString(...) function.
enum State {
// Uninitialized.
UNINITIALIZED,
@@ -80,6 +83,9 @@ class GCM_EXPORT GCMClientImpl : public GCMClient {
READY,
};
+ // Returns text representation of the enum State.
+ static std::string GetStateString(gcm::GCMClientImpl::State state);
jianli 2014/03/04 23:47:39 It seems to me that it is easier to define this as
juyik 2014/03/05 05:08:08 Done.
+
// The check-in info for the user. Returned by the server.
struct GCM_EXPORT CheckinInfo {
CheckinInfo() : android_id(0), secret(0) {}

Powered by Google App Engine
This is Rietveld 408576698