Show device information in chrome://gcm-internals page.

google_apis/gcm/gcm_client_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/gcm_client_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 395 matching lines @@
     mcs_proto::AppData* app_data = stanza.add_app_data();
     app_data->set_key(iter->first);
     app_data->set_value(iter->second);
   }
 
   MCSMessage mcs_message(stanza);
   DVLOG(1) << "MCS message size: " << mcs_message.size();
   mcs_client_->SendMessage(mcs_message);
 }
 
+std::string GCMClientImpl::GetStateString(gcm::GCMClientImpl::State state) {
+  switch(state) {
+    case GCMClientImpl::INITIALIZED:
+      return "INITIALIZED";
+    case GCMClientImpl::UNINITIALIZED:
+      return "UNINITIALIZED";
+    case GCMClientImpl::LOADING:
+      return "LOADING";
+    case GCMClientImpl::INITIAL_DEVICE_CHECKIN:
+      return "INITIAL_DEVICE_CHECKIN";
+    case GCMClientImpl::READY:
+      return "READY";

[jianli, 2014/03/04 23:47:39]

nit: Please handle default case.

[juyik, 2014/03/05 05:08:08]

Done.

+  }
+  return std::string();
+}
+
+GCMClient::GCMStatistics GCMClientImpl::GetStatistics() const {
+  GCMClient::GCMStatistics stats;
+  stats.gcm_client_state = GCMClientImpl::GetStateString(state_);
+  stats.connection_client_created = (mcs_client_.get() != NULL);

[jianli, 2014/03/04 23:47:39]

nit: parentheses are not needed 

[juyik, 2014/03/05 05:08:08]

Done.

+  if (mcs_client_.get()) {
+    stats.connection_state = MCSClient::GetStateString(mcs_client_->state());
+    // TODO(juyik): add more statistics such as message metadata list, etc.
+  }
+  return stats;
+}
+
 void GCMClientImpl::OnMessageReceivedFromMCS(const gcm::MCSMessage& message) {
   switch (message.tag()) {
     case kLoginResponseTag:
       DVLOG(1) << "Login response received by GCM Client. Ignoring.";
       return;
     case kDataMessageStanzaTag:
       DVLOG(1) << "A downstream message received. Processing...";
       HandleIncomingMessage(message);
       return;
     default:
@@ skipping 76 matching lines @@
   if (iter != incoming_message.data.end())
     message_id = iter->second;
   delegate->OnMessageSendError(app_id, message_id, SERVER_ERROR);
 }
 
 void GCMClientImpl::SetMCSClientForTesting(scoped_ptr<MCSClient> mcs_client) {
   mcs_client_ = mcs_client.Pass();
 }
 
 }  // namespace gcm