Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1768203002: Properly prepare boilerplate properties in the parser for the runtime (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly prepare boilerplate properties in the parser for the runtime BUG= Committed: https://crrev.com/8fab9c9b4e92dbd638a0f048fa7f37ed224b0256 Cr-Commit-Position: refs/heads/master@{#34582}

Patch Set 1 #

Patch Set 2 : Drop internalization #

Patch Set 3 : drop IsInternalized DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M src/ast/ast.cc View 1 1 chunk +7 lines, -10 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 2 1 chunk +3 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-07 16:52:54 UTC) #2
rossberg
lgtm
4 years, 9 months ago (2016-03-08 10:21:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768203002/40001
4 years, 9 months ago (2016-03-08 12:16:41 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 12:42:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 12:44:21 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8fab9c9b4e92dbd638a0f048fa7f37ed224b0256
Cr-Commit-Position: refs/heads/master@{#34582}

Powered by Google App Engine
This is Rietveld 408576698