Subzero: Count lookups of each constant value in the constant pool.

Subzero: Count lookups of each constant value in the constant pool.

With "-verbose cpool", at the end it dumps counts of the number of times each pooled constant was looked up.  The output is grouped by type and sorted by constant value, but it's easy to run it through "sort -nr" to see it ordered by popularity.

BUG= none
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9f9aa2c1953db5253dab1216cf44a9cbcb7cb176

[Jim Stichnoth, 2016-03-07 15:26:50]

Description was changed from

==========
Subzero: Count lookups of each constant value in the constant pool.

BUG= none
==========

to

==========
Subzero: Count lookups of each constant value in the constant pool.

With "-verbose cpool", at the end it dumps counts of the number of times each
pooled constant was looked up.  The output is grouped by type and sorted by
constant value, but it's easy to run it through "sort -nr" to see it ordered by
popularity.

BUG= none
==========

[Jim Stichnoth, 2016-03-07 15:26:50]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[John, 2016-03-07 15:50:26]

lgtm

https://codereview.chromium.org/1768173002/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1768173002/diff/1/src/IceGlobalContext.cpp#ne...
src/IceGlobalContext.cpp:775: for (Constant * C :
getConstPool()->WhichPool.getConstantPool()) {           \
auto? Anyway, remove the space between * and C

https://codereview.chromium.org/1768173002/diff/1/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/1768173002/diff/1/src/IceOperand.h#newcode131
src/IceOperand.h:131: std::conditional<BuildDefs::dump(), uint64_t,
uint8_t>::type;
What about void instead? Then you could use enable if below to provide 2
updateLookupCount... Might not work, though.

Or maybe just use an ifdef here?

[Jim Stichnoth, 2016-03-07 16:11:10]

Also did s/shouldBePooled/ShouldBePooled/ per LLVM conventions.

https://codereview.chromium.org/1768173002/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1768173002/diff/1/src/IceGlobalContext.cpp#ne...
src/IceGlobalContext.cpp:775: for (Constant * C :
getConstPool()->WhichPool.getConstantPool()) {           \
On 2016/03/07 15:50:26, John wrote:
> auto? Anyway, remove the space between * and C

Interesting, some sort of clang-format fail I guess...

Done.

https://codereview.chromium.org/1768173002/diff/1/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/1768173002/diff/1/src/IceOperand.h#newcode131
src/IceOperand.h:131: std::conditional<BuildDefs::dump(), uint64_t,
uint8_t>::type;
On 2016/03/07 15:50:26, John wrote:
> What about void instead? Then you could use enable if below to provide 2
> updateLookupCount... Might not work, though.
> 
> Or maybe just use an ifdef here?

You also need to conditionally declare the field and define its initializer,
since it seems you can't declare a void type field.

I want to minimize #ifdef code in general, to slow down rot.

The uint8_t field should fit it nicely alongside the bool ShouldBePooled field. 
If we ever remove ShouldBePooled from the base class, it should be clear that we
want to remove LookupCount as well in a minimal build.

[John, 2016-03-07 16:21:59]

lgtm

[Jim Stichnoth, 2016-03-07 16:25:28]

Description was changed from

==========
Subzero: Count lookups of each constant value in the constant pool.

With "-verbose cpool", at the end it dumps counts of the number of times each
pooled constant was looked up.  The output is grouped by type and sorted by
constant value, but it's easy to run it through "sort -nr" to see it ordered by
popularity.

BUG= none
==========

to

==========
Subzero: Count lookups of each constant value in the constant pool.

With "-verbose cpool", at the end it dumps counts of the number of times each
pooled constant was looked up.  The output is grouped by type and sorted by
constant value, but it's easy to run it through "sort -nr" to see it ordered by
popularity.

BUG= none
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-03-07 16:25:31]

Committed patchset #2 (id:20001) manually as
9f9aa2c1953db5253dab1216cf44a9cbcb7cb176 (presubmit successful).