Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1768153002: base: eliminate TupleTraits and TupleTypes (Closed)

Created:
4 years, 9 months ago by mdempsky
Modified:
4 years, 9 months ago
Reviewers:
danakj, tzik, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: eliminate TupleTraits and TupleTypes The only remaining use of these were base::TupleTypes<T>::ValueTuple, which just maps Tuple<Ts...> to Tuple<remove_reference_t<Ts>...>. However, all of the uses were for reference-free tuples, making it a noop. BUG=554987 Committed: https://crrev.com/390ab1e0cbc72313e9a4070424daa84e69d8b710 Cr-Commit-Position: refs/heads/master@{#379667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -47 lines) Patch
M base/tuple.h View 2 chunks +0 lines, -37 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/nacl_message_scanner.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mdempsky
4 years, 9 months ago (2016-03-07 15:48:37 UTC) #2
tzik
lgtm
4 years, 9 months ago (2016-03-07 18:46:19 UTC) #3
danakj
LGTM
4 years, 9 months ago (2016-03-07 21:35:16 UTC) #4
mdempsky
+piman for content and ppapi/proxy
4 years, 9 months ago (2016-03-07 21:37:17 UTC) #6
piman
lgtm
4 years, 9 months ago (2016-03-07 22:10:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768153002/1
4 years, 9 months ago (2016-03-07 22:11:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 22:18:46 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 22:20:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/390ab1e0cbc72313e9a4070424daa84e69d8b710
Cr-Commit-Position: refs/heads/master@{#379667}

Powered by Google App Engine
This is Rietveld 408576698