Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: chrome/browser/about_flags.cc

Issue 176813010: Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clean up comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 17c4aa0b5dfe835d0abf18f5f09aac797b07bc32..edae4f4cb001b15b5a8d8f1febf5ad9fc64045fd 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -190,6 +190,11 @@ const Experiment::Choice kNaClDebugMaskChoices[] = {
// Secure shell can be used on ChromeOS for forwarding the TCP port opened by
// debug stub to a remote machine. Since secure shell uses NaCl, we provide
// an option to switch off its debugging.
+ // The PNaCl translator is a NaCl module that runs before the user's
+ // actual NaCl module, so we want to be able to switch off debugging that.
+ { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS_PNACL,
+ switches::kNaClDebugMask,
+ "!*://*/*ssh_client.nmf,chrome://pnacl-translator/*" },
{ IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS,
switches::kNaClDebugMask, "!*://*/*ssh_client.nmf" },
{ IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG,

Powered by Google App Engine
This is Rietveld 408576698