Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <set>
@@ skipping 168 matching lines @@
   { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
     switches::kOverscrollHistoryNavigation,
     "0" },
   { IDS_OVERSCROLL_HISTORY_NAVIGATION_SIMPLE_UI,
     switches::kOverscrollHistoryNavigation,
     "2" }
 };
 #endif
 
 const Experiment::Choice kNaClDebugMaskChoices[] = {
-  { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
   // Secure shell can be used on ChromeOS for forwarding the TCP port opened by
-  // debug stub to a remote machine. Since secure shell uses NaCl, we provide
-  // an option to switch off its debugging.
-  { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS,
-      switches::kNaClDebugMask, "!*://*/*ssh_client.nmf" },
+  // debug stub to a remote machine. Since secure shell uses NaCl, we usually
+  // want to avoid debugging that. The PNaCl translator is also a NaCl module,
+  // so by default we want to avoid debugging that (the empty string will
+  // be overridden to the expected default).
+  { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS_PNACL, "", "" },

[bradn, 2014/03/06 18:56:34]

Maybe pull out the stuff in parens to:
NOTE: As the default value must be the empty string, the mask excluding the
PNaCl translator and secure shell is substituted in elsewhere.

[jvoung (off chromium), 2014/03/06 19:02:51]

Done.

+  { IDS_NACL_DEBUG_MASK_CHOICE_DEBUG_ALL, switches::kNaClDebugMask, "*://*" },
   { IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG,
       switches::kNaClDebugMask, "*://*/*debug.nmf" }
 };
 
 const Experiment::Choice kImplSidePaintingChoices[] = {
   { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
   { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
     cc::switches::kEnableImplSidePainting, ""},
   { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
     cc::switches::kDisableImplSidePainting, ""}
@@ skipping 2215 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags