Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: src/regexp/regexp-ast.h

Issue 1768093002: [regexp] Fix off-by-one in CharacterRange::Negate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/regexp/jsregexp.cc ('k') | test/mjsunit/regress/regress-crbug-592343.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp/regexp-ast.h
diff --git a/src/regexp/regexp-ast.h b/src/regexp/regexp-ast.h
index 4a81ccaf1b4444042e653a3f1a3e7f4fa071638f..89cbf9b9ff94c0eacdb3bbddce680c7d57aa3765 100644
--- a/src/regexp/regexp-ast.h
+++ b/src/regexp/regexp-ast.h
@@ -78,7 +78,9 @@ class CharacterRange {
CharacterRange() : from_(0), to_(0) {}
// For compatibility with the CHECK_OK macro
CharacterRange(void* null) { DCHECK_NULL(null); } // NOLINT
- CharacterRange(uc32 from, uc32 to) : from_(from), to_(to) {}
+ CharacterRange(uc32 from, uc32 to) : from_(from), to_(to) {
+ DCHECK(from <= to);
+ }
static void AddClassEscape(uc16 type, ZoneList<CharacterRange>* ranges,
Zone* zone);
static Vector<const int> GetWordBounds();
« no previous file with comments | « src/regexp/jsregexp.cc ('k') | test/mjsunit/regress/regress-crbug-592343.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698