Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1768093002: [regexp] Fix off-by-one in CharacterRange::Negate. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix off-by-one in CharacterRange::Negate. Character ranges starting at 1 are not correctly negated. R=jkummerow@chromium.org BUG=chromium:592343 LOG=Y Committed: https://crrev.com/f9d7c711afe0389e9c6c48f6653312017109cb6f Cr-Commit-Position: refs/heads/master@{#34528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/regexp/jsregexp.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/regexp/regexp-ast.h View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-592343.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
4 years, 9 months ago (2016-03-07 09:54:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768093002/1
4 years, 9 months ago (2016-03-07 09:57:37 UTC) #3
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-07 09:57:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768093002/1
4 years, 9 months ago (2016-03-07 09:59:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2429) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 10:25:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768093002/1
4 years, 9 months ago (2016-03-07 10:39:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 10:58:53 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 11:00:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9d7c711afe0389e9c6c48f6653312017109cb6f
Cr-Commit-Position: refs/heads/master@{#34528}

Powered by Google App Engine
This is Rietveld 408576698