Fill out more information in GrVkCaps

Fill out more information in GrVkCaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768083003

Committed: https://skia.googlesource.com/skia/+/d5e3b9e1e0f93a4722c20bb095079cde7ad80dc4

[egdaniel, 2016-03-07 18:26:47]

Description was changed from

==========
Fill out more information in GrVkCaps

BUG=skia:
==========

to

==========
Fill out more information in GrVkCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-03-07 18:30:40]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[egdaniel, 2016-03-07 18:30:41]

Some basic updates to VkCaps

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:132: glslCaps->fVersionDeclString = "#version 450\n";
I haven't found anything in vulkan or shaderc that lets you query for some glsl
supported version. I have seen many examples out there using version 450. Do you
guys think it hurts to just use this?

[bsalomon, 2016-03-07 19:34:08]

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:132: glslCaps->fVersionDeclString = "#version 450\n";
On 2016/03/07 18:30:41, egdaniel wrote:
> I haven't found anything in vulkan or shaderc that lets you query for some
glsl
> supported version. I have seen many examples out there using version 450. Do
you
> guys think it hurts to just use this?

Maybe a question for the shaderc team?

[egdaniel, 2016-03-07 21:31:12]

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1768083003/diff/20001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:132: glslCaps->fVersionDeclString = "#version 450\n";
On 2016/03/07 19:34:08, bsalomon wrote:
> On 2016/03/07 18:30:41, egdaniel wrote:
> > I haven't found anything in vulkan or shaderc that lets you query for some
> glsl
> > supported version. I have seen many examples out there using version 450. Do
> you
> > guys think it hurts to just use this?
> 
> Maybe a question for the shaderc team?

Talked to shaderc folks. The claim is anything about 140 or 310 is supported.
Changed to 310 es to match assumed GLES support

[bsalomon, 2016-03-08 14:57:48]

lgtm

[jvanverth1, 2016-03-08 15:55:57]

Looks okay to me too. Are the cached and coherent memory caps going in a
different change?

https://codereview.chromium.org/1768083003/diff/40001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1768083003/diff/40001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:110: // We could actually querey and get a max size for
each config, however maxImageDimension2D will
sp: query

[egdaniel, 2016-03-08 16:03:06]

Yeah I just wanted to do this change of filling out already existing caps. I'll
then go back and do the specific new ones we wanted added in a follow up

https://codereview.chromium.org/1768083003/diff/40001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1768083003/diff/40001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:110: // We could actually querey and get a max size for
each config, however maxImageDimension2D will
On 2016/03/08 15:55:57, jvanverth1 wrote:
> sp: query

Done.

[egdaniel, 2016-03-08 20:07:59]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-03-08 20:07:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1768083003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-08 20:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768083003/80001

[commit-bot: I haz the power, 2016-03-08 20:19:57]

Description was changed from

==========
Fill out more information in GrVkCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fill out more information in GrVkCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d5e3b9e1e0f93a4722c20bb095079cde7ad80dc4
==========

[commit-bot: I haz the power, 2016-03-08 20:19:58]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d5e3b9e1e0f93a4722c20bb095079cde7ad80dc4