Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1768083002: Add CharacterData.h to input for Character Data generation step (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 9 months ago
Reviewers:
dpranke, kojii
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CharacterData.h to input for Character Data generation step Without this line, touching CharacterData.h does not trigger regenerating the serialized character data tables. R=kojii,dpranke BUG=592364 Committed: https://crrev.com/7cf618b62ddd0efab7da0449c67b64a67d3bc397 Cr-Commit-Position: refs/heads/master@{#379561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/platform_generated.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
drott
4 years, 9 months ago (2016-03-07 09:48:26 UTC) #1
kojii
lgtm, sorry that was my fault.
4 years, 9 months ago (2016-03-07 14:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768083002/1
4 years, 9 months ago (2016-03-07 15:11:00 UTC) #4
drott
Thanks for the quick review, no worries, just noticed this when updating CharacterData in a ...
4 years, 9 months ago (2016-03-07 15:12:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 16:37:08 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 16:39:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cf618b62ddd0efab7da0449c67b64a67d3bc397
Cr-Commit-Position: refs/heads/master@{#379561}

Powered by Google App Engine
This is Rietveld 408576698