content/renderer/cache_storage/cache_storage_dispatcher.h - Issue 1768063002: Introduce String::fromUTF8Lenient() and use it for cache_name in CacheStorage API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/cache_storage/cache_storage_dispatcher.h

Issue 1768063002: Introduce String::fromUTF8Lenient() and use it for cache_name in CacheStorage API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated jsbell's comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/cache_storage/cache_storage_types.h ('k') | content/renderer/cache_storage/cache_storage_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/cache_storage/cache_storage_dispatcher.h

diff --git a/content/renderer/cache_storage/cache_storage_dispatcher.h b/content/renderer/cache_storage/cache_storage_dispatcher.h

index a43757d0f82aae56913aa563b90648ff81e36fe4..33b093d0dedda558703b4355d9cbf9a5a830d3a5 100644

--- a/content/renderer/cache_storage/cache_storage_dispatcher.h

+++ b/content/renderer/cache_storage/cache_storage_dispatcher.h

@@ -52,7 +52,7 @@ class CacheStorageDispatcher : public WorkerThread::Observer {

void OnCacheStorageDeleteSuccess(int thread_id, int request_id);

void OnCacheStorageKeysSuccess(int thread_id,

int request_id,

- const std::vector<base::string16>& keys);

+ const std::vector<std::string>& keys);

void OnCacheStorageMatchSuccess(int thread_id,

int request_id,

const ServiceWorkerResponse& response);

« no previous file with comments | « content/common/cache_storage/cache_storage_types.h ('k') | content/renderer/cache_storage/cache_storage_dispatcher.cc » ('j') | no next file with comments »