content/common/cache_storage/cache_storage_messages.h - Issue 1768063002: Introduce String::fromUTF8Lenient() and use it for cache_name in CacheStorage API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/cache_storage/cache_storage_messages.h

Issue 1768063002: Introduce String::fromUTF8Lenient() and use it for cache_name in CacheStorage API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated jsbell's comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cache_storage/cache_storage_dispatcher_host.cc ('k') | content/common/cache_storage/cache_storage_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/cache_storage/cache_storage_messages.h

diff --git a/content/common/cache_storage/cache_storage_messages.h b/content/common/cache_storage/cache_storage_messages.h

index 277f960ee6e9ec08caea2aad4b4c6a49c9ceb36d..aaf00439875b6621f1d88a46c2266b46e6f54755 100644

--- a/content/common/cache_storage/cache_storage_messages.h

+++ b/content/common/cache_storage/cache_storage_messages.h

@@ -52,19 +52,19 @@ IPC_MESSAGE_CONTROL4(CacheStorageHostMsg_CacheStorageHas,

int /* thread_id */,

int /* request_id */,

GURL /* origin */,

- base::string16 /* fetch_store_name */)

+ std::string /* fetch_store_name */)

IPC_MESSAGE_CONTROL4(CacheStorageHostMsg_CacheStorageOpen,

int /* thread_id */,

int /* request_id */,

GURL /* origin */,

- base::string16 /* fetch_store_name */)

+ std::string /* fetch_store_name */)

IPC_MESSAGE_CONTROL4(CacheStorageHostMsg_CacheStorageDelete,

int /* thread_id */,

int /* request_id */,

GURL /* origin */,

- base::string16 /* fetch_store_name */)

+ std::string /* fetch_store_name */)

IPC_MESSAGE_CONTROL3(CacheStorageHostMsg_CacheStorageKeys,

int /* thread_id */,

@@ -133,7 +133,7 @@ IPC_MESSAGE_CONTROL2(CacheStorageMsg_CacheStorageDeleteSuccess,

IPC_MESSAGE_CONTROL3(CacheStorageMsg_CacheStorageKeysSuccess,

int /* thread_id */,

int /* request_id */,

- std::vector<base::string16> /* keys */)

+ std::vector<std::string> /* keys */)

IPC_MESSAGE_CONTROL3(CacheStorageMsg_CacheStorageMatchSuccess,

int /* thread_id */,

int /* request_id */,